fix: prevent feedback from appearing in the inline-code-snippet field #7194
Conversation
|
Deploy preview for carbon-elements ready! Built with commit 874e159 |
|
Deploy preview for carbon-components-react ready! Built without sensitive environment variables with commit 874e159 https://deploy-preview-7194--carbon-components-react.netlify.app |
| @@ -68,7 +68,6 @@ export default function Copy({ | |||
| (!children && (animation ? feedback : other['aria-label'])) || null | |||
| }> | |||
| {children} | |||
| {animation ? feedback : other['aria-label']} | |||
There was a problem hiding this comment.
I don't think we can remove this line since it announces the feedback to screenreaders IIRC
There was a problem hiding this comment.
Could we change the aria-label to the button as follows ?
<button ... aria-label={animation ? feedback : other['aria-label']}> ... </button>
There was a problem hiding this comment.
I'm not sure if we need to change the component at all since the issue you reported is only found in the website. as I mentioned earlier I believe a font-size style rule is being overwritten in the website stylesheet but I haven't looked into it closely
|
Going to close this out due to @emyarod's feedback that this is most likely related to the website as the component does not reflect this behavior in the storybook. Feel free to re-open if I've made a mistake here! |
Fixes first part of carbon-design-system/carbon-website#1932
In the live demo, the feedback text was appearing in the code-snippet field (for inline type). This has now been prevented from appearing.
Changelog
Removed
Testing / Reviewing
Before
After